fix(desktop): clarify CLI runtime setup#2680
Conversation
Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com> Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com> Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com> Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com> Co-authored-by: Codex <noreply@openai.com>
|
hey @atishpatel — consolidated review feedback from two independent passes at 1. (important, flagged independently by both reviewers) 2. (minor) 3. (minor) The Goose Windows installer is pinned to the mutable 4. (minor) In 5. (nit) 6. (nit) 7. (nit) Two unrelated blank-line deletions in Item 1 is the only merge-blocker from our side. CI is fully green at head. |
Move external CLI guidance into runtime catalog metadata and make post-install rediscovery targeted and auth-probe-free. Clarify setup labels and the Goose Windows installer constraint. Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com> Co-authored-by: Goose <opensource@block.xyz>
Resolve the Doctor runtime-row conflict by preserving main's per-row install state and the review follow-up's CLI setup label. Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com>
|
🤖 Addressed all seven review items in f19b483 (included in current merge head 9d1faf2):
The branch was also merged with current origin/main; GitHub CI is the validation gate for head 9d1faf2. |
Keep main's per-runtime mutation state without retaining the optimistic-success binding removed by post-install verification. Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com> Co-authored-by: Codex <noreply@openai.com>
Align Doctor E2E assertions with the review-requested CLI setup guide label. Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com> Co-authored-by: Codex <noreply@openai.com>
Why
Installing the Codex, Claude, or Goose desktop app does not install the command-line harness Buzz needs. The current UI makes that distinction unclear, links some missing-CLI states to adapter documentation, and can report a successful install from the installer exit code even when runtime discovery still fails. On Windows, Buzz also invokes Goose's Bash installer, which writes the executable somewhere Buzz does not discover.
What
Risk Assessment
Medium. This changes desktop onboarding and runtime installation behavior. Successful installs now require the runtime catalog to verify availability; previously hidden discovery failures will surface as actionable errors instead of a false success state.
References
Validation
just desktop-typecheckjust desktop-test— 3,455 passedGenerated with Codex